I've always felt that it was completely pointless to mash the buttons, whether it's the A, B, D-pad, touch screen, etc.
But I won't lie, I've noticed here and there when I get really excited about my chances of catching (especially since I only catch legendaries with poke-balls), my thumbs will just start mashing on their own.